Replaced not-working multiple socket functionality #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason it was not working is blocking nature of ListenAndServe call. New implementation moves it into goroutine and tracks possible exceptions via "select" block.
joewalnes
added a commit
that referenced
this pull request
Feb 20, 2014
Replaced not-working multiple socket functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason it was not working is blocking nature of ListenAndServe call. New implementation moves it into goroutine and tracks possible exceptions via "select" block.
Joe, sorry I did not check as carefully as I should first time I implemented it. Looks like I was always checking first --address and never looked that second one was not working (now it showed up in my serverspec tests).