Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons with a dot (.) in the filename are not found #536

Closed
JWMKit opened this issue Dec 10, 2021 · 1 comment
Closed

icons with a dot (.) in the filename are not found #536

JWMKit opened this issue Dec 10, 2021 · 1 comment
Milestone

Comments

@JWMKit
Copy link

JWMKit commented Dec 10, 2021

Summary : JWM does not find images with a dot (.) in the filename when searching the iconpaths unless the file extension is specified.

Version: jwm v2.4.0
compiled options: confirm icons jpeg nls pango png shape svg xbm xft xinerama xpm xrender

Expected behavior
Users can reference an icon by it's filename only. No extension, or path is needed because JWM searches the IconPaths defined in jwmrc.

For example with the iconpath "$HOME/.local/share/icons/" declared in jwmrc we can reference the file $HOME/.local/share/icons/utilities-terminal.svg in a menu item or traybutton with the icon attribute like this: icon="utilities-terminal"

Unexpected behavior (The Problem)
Images with a filename containing a dot (.) are not found unless you specify the the extension.

To demonstrate rename the file by changing the dash to a dot in the file so we now have this:
$HOME/.local/share/icons/utilities.terminal.svg

You would expect the same behavior for this file, but apparently the dot (.) in the filename confuses it. So you must add the file extension .svg for JWM to find it. Like this:
icon="utilities.terminal.svg"

@joewing
Copy link
Owner

joewing commented Dec 15, 2021

Thanks, this should be fixed in master now for the next release.

@joewing joewing added this to the Version 2.4.1 milestone Dec 15, 2021
@joewing joewing closed this as completed Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants