Fixed visibility of menu items in different statuses of window #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(!(np->state.status & STAT_FULLSCREEN) && | ||
| !(np->state.status & STAT_MINIMIZED) && | ||
| (np->state.border & BORDER_MIN)) | ||
| { |
There was a problem hiding this comment.
I think the goal here is to hide the shade/unshade options if either the window is minimized or if it does not support minimization, correct? That seems reasonable to me, but this will also prevent maximization in that case, which I don’t think is desirable. There should probably be another if statement surrounding just the shade portion.
There was a problem hiding this comment.
IMHO, if the window is minimized then it is not visible. You can not run commands:
- Shade
- Unshade
- Maximize-x
- Maximize-y
- Maximize
- Restore
There was a problem hiding this comment.
My opinion has changed ;) You can not run commands:
- Shade
- Unshade
- Restore from maximizing
…window is minimized. Removed visibility of menu items Shaded/Unshaded when window is minimized.
|
I corrected my pull request. Please look it. |
|
Thanks! |
|
@joewing, sorry for my code style. Thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.