Add WM_CLIENT_MACHINE tag for the group settings #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forget something...
joewing
reviewed
Apr 20, 2018
src/event.c
Outdated
| break; | ||
| case XA_WM_CLIENT_MACHINE: | ||
| ReadWMMachine(np); | ||
| changed = 1; |
|
Thanks for implementing this! I can definitely see this as being useful to others. |
joewing
reviewed
Apr 20, 2018
src/hint.c
Outdated
| XTextProperty tprop; | ||
| char **tlist; | ||
| int tcount; | ||
|
|
There was a problem hiding this comment.
I think we want something along the lines of the following here:
if(np->machineName) {
Release(np->machineName);
np->machineName = NULL;
}I haven't looked carefully yet, but is machineName getting set to NULL when ClientNode is allocated and freed when deleted?
There was a problem hiding this comment.
You're right, i was missing that.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be beneficial for more users then just me: use WM_CLIENT_MACHINE (as
<Group><Machine>foo</Machine>...) , so programs startet from a different host (e.g. ssh -X ...) can be grouped.