-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WM_CLIENT_MACHINE tag for the group settings #459
Conversation
Forget something...
src/event.c
Outdated
break; | ||
case XA_WM_CLIENT_MACHINE: | ||
ReadWMMachine(np); | ||
changed = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want a break
here?
Thanks for implementing this! I can definitely see this as being useful to others. |
src/hint.c
Outdated
XTextProperty tprop; | ||
char **tlist; | ||
int tcount; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want something along the lines of the following here:
if(np->machineName) {
Release(np->machineName);
np->machineName = NULL;
}
I haven't looked carefully yet, but is machineName getting set to NULL when ClientNode is allocated and freed when deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, i was missing that.
Thanks! |
This may be beneficial for more users then just me: use WM_CLIENT_MACHINE (as
<Group><Machine>foo</Machine>...
) , so programs startet from a different host (e.g. ssh -X ...) can be grouped.