Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle click close on taskbar #548

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Middle click close on taskbar #548

merged 1 commit into from
Feb 19, 2022

Conversation

keshto
Copy link
Contributor

@keshto keshto commented Feb 18, 2022

This adds a close on middle click to taskbar. Better than this would be to utilize whatever keybinding is for middle click on the titlebar context (I couldn't figure out how to get that setting). Best would be have a taskbar context for mouse keybindings so one could do whatever they wanted.

Related issue #541

@joewing
Copy link
Owner

joewing commented Feb 19, 2022

I agree that we should probably have a mouse context for the taskbar. It likely wouldn't be terribly difficult to implement, the biggest complication I see is that a taskbar entry can be multiple clients, so the actions would need to somehow handle that (and obviously, the current left-click action would have to be supported).

In any case, given that nothing is associated with Button2 yet, I think it's reasonable to use it for something. I guess my biggest concern would be an accidental click causing delete, but might as well give it a try!

@joewing joewing merged commit ff8228c into joewing:master Feb 19, 2022
@keshto
Copy link
Contributor Author

keshto commented Feb 19, 2022 via email

@yetanothergeek
Copy link

I'm sure this is a wonderful idea for some users, but for me it's terrible. Until there is some way to disable it, I think it should be reverted.

@keshto
Copy link
Contributor Author

keshto commented Jul 10, 2022 via email

@yetanothergeek
Copy link

I can do a PR to revert it, how about that?

@keshto
Copy link
Contributor Author

keshto commented Jul 10, 2022 via email

@yetanothergeek
Copy link

If it was an easy task, you would have done it yourself when you added the feature. Or at least sometime in the six months since then. My point is that until somebody adds a configuration option, the feature should be disabled because it is incomplete as is.

@keshto keshto deleted the patch-1 branch July 11, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants