-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middle click close on taskbar #548
Conversation
I agree that we should probably have a mouse context for the taskbar. It likely wouldn't be terribly difficult to implement, the biggest complication I see is that a taskbar entry can be multiple clients, so the actions would need to somehow handle that (and obviously, the current left-click action would have to be supported). In any case, given that nothing is associated with Button2 yet, I think it's reasonable to use it for something. I guess my biggest concern would be an accidental click causing delete, but might as well give it a try! |
I couldnt figure out how to assign it the same action as the mousebiinding for middle click ok taskbar but I think that would be easiest compromise. Because misclicl and you app close when not expected could be annoying to some. Where as someone who specifically makes a middle click action for titlebar would expect the same to happen on the taskbar
…On February 19, 2022 2:32:16 PM UTC, Joe Wingbermuehle ***@***.***> wrote:
I agree that we should probably have a mouse context for the taskbar. It likely wouldn't be terribly difficult to implement, the biggest complication I see is that a taskbar entry can be multiple clients, so the actions would need to somehow handle that (and obviously, the current left-click action would have to be supported).
In any case, given that nothing is associated with Button2 yet, I think it's reasonable to use it for something. I guess my biggest concern would be an accidental click causing delete, but might as well give it a try!
--
Reply to this email directly or view it on GitHub:
#548 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
I'm sure this is a wonderful idea for some users, but for me it's terrible. Until there is some way to disable it, I think it should be reverted. |
I did the PR for the feature. You can contribute an option to enable/disable it.
…On July 9, 2022 11:58:47 PM UTC, Jeff Pohlmeyer ***@***.***> wrote:
I'm sure this is a wonderful idea for some users, but for me it's terrible. Until there is some way to disable it, I think it should be reverted.
--
Reply to this email directly or view it on GitHub:
#548 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
I can do a PR to revert it, how about that? |
That is not very respectful of the work I did to get it in.
If you need help making it configurable I can help you.
…On July 10, 2022 12:07:33 AM UTC, Jeff Pohlmeyer ***@***.***> wrote:
I can do a PR to revert it, how about that?
--
Reply to this email directly or view it on GitHub:
#548 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
If it was an easy task, you would have done it yourself when you added the feature. Or at least sometime in the six months since then. My point is that until somebody adds a configuration option, the feature should be disabled because it is incomplete as is. |
This adds a close on middle click to taskbar. Better than this would be to utilize whatever keybinding is for middle click on the titlebar context (I couldn't figure out how to get that setting). Best would be have a taskbar context for mouse keybindings so one could do whatever they wanted.
Related issue #541