Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical gradients #632

Merged
merged 10 commits into from
Aug 4, 2024
Merged

Vertical gradients #632

merged 10 commits into from
Aug 4, 2024

Conversation

joewing
Copy link
Owner

@joewing joewing commented Aug 2, 2024

This builds on the work from @BlackCodec in #593 and implements vertical gradients everywhere a gradient is supported. I'm still checking through all the cases.

@joewing joewing mentioned this pull request Aug 2, 2024
src/color.c Outdated
@@ -338,6 +341,7 @@ unsigned long GetRGBFromXColor(const XColor *c)
return red | green | blue;
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary newline?

src/color.c Outdated
gradients[b] = d;
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last extra newline

@joewing joewing merged commit a4318c5 into master Aug 4, 2024
@joewing joewing deleted the vertical-gradients branch August 4, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants