Add theme support #335
Closed
Add theme support #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Thanks! It will be nice to have this merged |
|
Unfortunately I think this project is dead. Last commit was 2 years ago, and the maintainer is not responding to any issues or PRs. |
|
Have you tried pinging joeyespo on twitter? http://twitter.com/joeyespo |
|
@diachedelic I have too much other stuff going on, it isn't that important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for this fantastic tool!
This PR adds support for setting the default theme. The standard GitHub
Light,Dark, andDark dimmedthemes are supported. The theme can be set in the config file via aTHEMEvariable, via--theme=<theme>on the command line, or dynamically via a menu in generated non-user content pages.The template JavaScript has also been modernized to use
constandletinstead ofvar. GitHub does not support any browsers that do not support this, there's no reason for Grip to.API and CLI tests have been updated. Note the GitHub tests were failing before this PR, I didn't bother fixing them.