Fix issue #89 and encoding #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is default when using Python 3.3.
|
This looks great. The references answered all the questions I had. Thank you for the fixes and the rationale behind them, @alexandre-mbm! |
|
So this is an older issue, but I reverted the When you added that, was it intended just to be used when requesting from the local filesystem? I tweaked the code that saves and loads the cached files, so let me know if this is broken for you again in the next release. |
|
A few months ago, I separated me of Microsoft Windows another time. Then I will cannot test this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Windows 7 with Python 3.3 and the packages
requests,setuptoolsandpipfrom ~gohlke/pythonlibs's executable installers. See about in "How to install pip on Windows?".References for 06d0426:
References for 31cb6d7: