Transform assignments to private named instance fields #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeywatts
force-pushed
the
esnext-private-fields-access
branch
from
39ab860 to
2920db0
Compare
joeywatts
force-pushed
the
esnext-private-fields-assignment
branch
from
5a12944 to
c527c53
Compare
joeywatts
force-pushed
the
esnext-private-fields-access
branch
from
2920db0 to
5f03c9b
Compare
joeywatts
force-pushed
the
esnext-private-fields-assignment
branch
from
c527c53 to
5884da5
Compare
joeywatts
force-pushed
the
esnext-private-fields-access
branch
from
5f03c9b to
3341558
Compare
added 4 commits
October 25, 2018 13:48
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
joeywatts
force-pushed
the
esnext-private-fields-assignment
branch
from
5884da5 to
083b4cb
Compare
joeywatts
pushed a commit
that referenced
this pull request
Nov 21, 2018
Moves the transformation of class properties to the ESNext transformer.
Property initializers are moved to the constructor by the TypeScript transformer only if there is constructor parameter properties. This is to preserve property initialization order.
It currently does not produce void 0 initializers for property declarations that have no initializer due to ESNext and TypeScript having different runtime behaviors. TS completely elides property declarations with no initializer, while I believe the ESNext would define that property on the instance with an undefined value (which is observable at runtime - propertyName in instance or for (var prop in instance) {}).
|
closed (refer to bloomberg#15) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.