Fix error in NautilusSampler when saving outputs #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ajshajib - many thanks for this! Many of the changes seem to be formatting-only, which confuses the PR. Would you be able to revert those changes and just leave the ones that make the actual change, so I can understand it properly? I think many editors make these changes automatically. Cheers, |
joezuntz
reviewed
Jan 7, 2025
|
I have reverted the formatting-only changes. |
|
Thanks! Just running the tests now then once they pass I will merge. |
joezuntz
approved these changes
Jan 7, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error when saving the output from the Nautilus sampler. It checks whether the
blobvariable is an array of floats or tuples and then refactors them appropriately for saving/processing. This will close #162.