Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 chore(package.json): update date-fns dependency to version ^2.30.0 #53

Merged
merged 5 commits into from
Aug 16, 2023

Conversation

ejcenteno
Copy link
Contributor

Update date-fns dependency to version ^2.30.0 for compatibility and potential bug fixes

The date-fns dependency has been updated to version ^2.30.0 to ensure compatibility with the latest features and bug fixes.

…for compatibility and potential bug fixes

The date-fns dependency has been updated to version ^2.30.0 to ensure compatibility with the latest features and bug fixes.
… expected output

The date format in the test case was incorrect. It was using 'YYYY' instead of 'yyyy' for the year format. This caused the test to fail. The date format has been fixed to 'MMM dd, yyyy' to match the expected output.
📚 chore(DOC.md): update link to date-fns format documentation
The `morph-date-format` function in the DOC.md file has been updated to use `date-fns@v2.30.0` instead of `date-fns@v1.30.1`. This update ensures compatibility with the latest version of `date-fns` and provides access to the latest features
Copy link
Owner

@jofftiquez jofftiquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments. Thanks.

DOC.md Outdated Show resolved Hide resolved
…ct the correct age

The constant CHESTER_BENNINGTON_AGE has been updated from 44 to 47 to reflect the correct age of Chester Bennington. This change ensures that the test case accurately represents the expected age.
…rrect time display

The unnecessary dots in the time format have been removed to fix the incorrect time display.
@ejcenteno ejcenteno requested a review from jofftiquez August 16, 2023 16:01
@ejcenteno
Copy link
Contributor Author

Here's the result of the unit testing,
image

@jofftiquez jofftiquez merged commit fb6bb03 into jofftiquez:main Aug 16, 2023
@jofftiquez
Copy link
Owner

@ejcenteno publish in v1.2.1 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants