Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #59

Merged
merged 10 commits into from
Nov 30, 2019
Merged

Improve code quality #59

merged 10 commits into from
Nov 30, 2019

Conversation

jogboms
Copy link
Owner

@jogboms jogboms commented Oct 19, 2019

Fixes #60
Fixes #57

@jogboms jogboms force-pushed the improve-code-quality branch 2 times, most recently from bcddb3d to a9d7e4e Compare October 19, 2019 21:36
@jogboms jogboms requested a review from aagarwal1012 October 19, 2019 21:36
@jogboms jogboms force-pushed the improve-code-quality branch 2 times, most recently from 519d0ef to e92fd1b Compare November 23, 2019 19:19
@jogboms jogboms changed the title WIP: Improve code quality Improve code quality Nov 23, 2019
@jogboms
Copy link
Owner Author

jogboms commented Nov 23, 2019

@aagarwal1012 This is how far I can go for now, what do you think?

@aagarwal1012
Copy link
Collaborator

@jogboms, changes look really good. Awesome work!

@aagarwal1012
Copy link
Collaborator

This time don't make a Squash Merge.

@jogboms jogboms force-pushed the improve-code-quality branch 4 times, most recently from 5e2aaad to 1683760 Compare November 30, 2019 10:15
@jogboms jogboms force-pushed the improve-code-quality branch 4 times, most recently from 14e1141 to 0470128 Compare November 30, 2019 10:34
@jogboms jogboms force-pushed the improve-code-quality branch from 0470128 to 3b2d9a6 Compare November 30, 2019 10:35
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@636d940). Click here to learn what that means.
The diff coverage is 99.74%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   98.76%           
=========================================
  Files             ?       24           
  Lines             ?      890           
  Branches          ?        0           
=========================================
  Hits              ?      879           
  Misses            ?       11           
  Partials          ?        0
Impacted Files Coverage Δ
lib/src/spinning_circle.dart 100% <100%> (ø)
lib/src/hour_glass.dart 100% <100%> (ø)
lib/src/three_bounce.dart 100% <100%> (ø)
lib/src/rotating_plain.dart 100% <100%> (ø)
lib/src/folding_cube.dart 100% <100%> (ø)
lib/src/ripple.dart 100% <100%> (ø)
lib/src/circle.dart 100% <100%> (ø)
lib/src/rotating_circle.dart 100% <100%> (ø)
lib/src/pulse.dart 100% <100%> (ø)
lib/src/fading_grid.dart 100% <100%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636d940...3b2d9a6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"RotatingPlane" is called "RotatingPlain" in code Use SpinKitRipple without MaterialApp context may crash
4 participants