Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpinKitWave now have item count parameter #71

Merged
merged 2 commits into from
Feb 21, 2020
Merged

SpinKitWave now have item count parameter #71

merged 2 commits into from
Feb 21, 2020

Conversation

payam-zahedi
Copy link
Contributor

Hi, I made some changes to SpinKitWave and make it more flexible. SpinKitWave now has itemCount property. It will help the user to choose number of waves.

  • itemCount property added to SpinKitWave Widget.
  • getAnimationDelay now works dynamically.
  • and the width of each element is calculated according to itemCount.

check the demo in DartPad

If you have any changes, please let me know.
thanks.

Copy link
Owner

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @payam-zahedi. Thanks

lib/src/wave.dart Outdated Show resolved Hide resolved
lib/src/wave.dart Show resolved Hide resolved
@payam-zahedi payam-zahedi removed the request for review from aagarwal1012 February 11, 2020 16:17
@codecov-io
Copy link

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          24     24           
  Lines         867    887   +20     
=====================================
+ Hits          867    887   +20
Impacted Files Coverage Δ
lib/src/wave.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7482173...409858f. Read the comment docs.

Copy link
Owner

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jogboms jogboms merged commit 6cb0b66 into jogboms:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants