fix(events-targets): allow adding same scheduled fargate task to mult…

…iple rules Also allow adding same scheduled fargate task multiple times to same rule. Closes aws#3574
jogold · Aug 7, 2019 · b8f68d1 · b8f68d1
1 parent f4ca41c
commit b8f68d1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...ges/@aws-cdk/aws-ecs-patterns/test/fargate/integ.scheduled-fargate-task.lit.expected.json b/...ges/@aws-cdk/aws-ecs-patterns/test/fargate/integ.scheduled-fargate-task.lit.expected.json
@@ -632,7 +632,7 @@
         ]
       }
     },
-    "ScheduledFargateTaskScheduledTaskDefPutTargets7149EAB4": {
+    "ScheduledFargateTaskScheduledTaskDefScheduledEventRuleTarget0PutTargets4F6BAABA": {
       "Type": "Custom::AWS",
       "Properties": {
         "ServiceToken": {

diff --git a/packages/@aws-cdk/aws-events-targets/lib/ecs-task.ts b/packages/@aws-cdk/aws-events-targets/lib/ecs-task.ts
@@ -117,7 +117,7 @@ export class EcsTask implements events.IRuleTarget {
       const subnetSelection = this.props.subnetSelection || { subnetType: ec2.SubnetType.PRIVATE };
       const assignPublicIp = subnetSelection.subnetType === ec2.SubnetType.PRIVATE ? 'DISABLED' : 'ENABLED';
 
-      new custom.AwsCustomResource(this.taskDefinition, 'PutTargets', {
+      new custom.AwsCustomResource(this.taskDefinition, `${rule.node.id}${id}PutTargets`, {
         // `onCreate´ defaults to `onUpdate` and we don't need an `onDelete` here
         // because the rule/target will be owned by CF anyway.
         onUpdate: {

diff --git a/packages/@aws-cdk/aws-events-targets/test/ecs/integ.event-fargate-task.expected.json b/packages/@aws-cdk/aws-events-targets/test/ecs/integ.event-fargate-task.expected.json
@@ -595,7 +595,7 @@
         ]
       }
     },
-    "TaskDefPutTargetsF699575F": {
+    "TaskDefRuleTarget0PutTargets77691785": {
       "Type": "Custom::AWS",
       "Properties": {
         "ServiceToken": {