Add JDK8/JDK17 into CI matrix #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
reviewed
Mar 11, 2022
.github/workflows/ci.yml
Outdated
Comment on lines
34
to
40
| - name: Setup Java (temurin@8) | ||
| if: matrix.java == 'temurin@8' | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 8 | ||
|
|
There was a problem hiding this comment.
Given that Java 8 was eol 2019 I think we can skip that, adding 17 is good though.
Suggested change
| - name: Setup Java (temurin@8) | |
| if: matrix.java == 'temurin@8' | |
| uses: actions/setup-java@v2 | |
| with: | |
| distribution: temurin | |
| java-version: 8 |
.github/workflows/ci.yml
Outdated
| @@ -23,21 +23,35 @@ jobs: | |||
| matrix: | |||
| os: [ubuntu-latest] | |||
| scala: [2.12.15, 2.11.12, 2.13.8] | |||
| java: [temurin@11] | |||
| java: [temurin@8, temurin@11, temurin@17] | |||
There was a problem hiding this comment.
Suggested change
| java: [temurin@8, temurin@11, temurin@17] | |
| java: [temurin@11, temurin@17] |
build.sbt
Outdated
| @@ -68,6 +68,12 @@ developers := List( | |||
| Developer("johanandren", "Johan Andrén", "johan@markatta.com", url("https://markatta.com/johan/codemonkey")) | |||
| ) | |||
|
|
|||
| ThisBuild / githubWorkflowJavaVersions := List( | |||
| JavaSpec.temurin("8"), | |||
There was a problem hiding this comment.
Suggested change
| JavaSpec.temurin("8"), |
mdedetrich
force-pushed
the
add-jdk8-djk17-into-ci-matrix
branch
from
da25ec4 to
18e2bf7
Compare
|
@johanandren Just updated + rebased the PR with JDK 8 removed |
mdedetrich
force-pushed
the
add-jdk8-djk17-into-ci-matrix
branch
from
18e2bf7 to
ee1b78d
Compare
johanandren
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JDK8/JDK17 into the CI build matrix. Remember to also update the github branch status checks after the PR gets merged.