Add sbt-ci-release #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
commented
Apr 4, 2022
| Test / publishArtifact := false | ||
| pomIncludeRepository := { _ => false } | ||
| publishTo := sonatypePublishTo.value |
There was a problem hiding this comment.
These values were removed because they are provided by sbt-ci-release, see https://github.com/sbt/sbt-ci-release#sbt
mdedetrich
commented
Apr 4, 2022
| @@ -1 +0,0 @@ | |||
| ThisBuild / version := "2.0.2-SNAPSHOT" | |||
There was a problem hiding this comment.
version.sbt was removed because sbt-ci-release handles the versioning https://github.com/sbt/sbt-ci-release#sbt .
mdedetrich
force-pushed
the
sbt-ci-release
branch
2 times, most recently
from
eacaa5d to
3c8af28
Compare
mdedetrich
force-pushed
the
sbt-ci-release
branch
2 times, most recently
from
e8f6273 to
962478d
Compare
mdedetrich
force-pushed
the
sbt-ci-release
branch
from
962478d to
70c674f
Compare
|
Okay PR is ready now. |
|
Thanks a bunch! |
|
@johanandren Would it be possible to make a release? Just want to make sure everything is working (and it will also contain the newest |
|
I just did, 2.0.2 is on maven central already :) |
|
Yeah was about to say, just noticed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sbt-ci-release to the project.
Resolves: #35
Note that the changes to
.github/workflows/ci.ymlare all due to thesbt-github-actionsplugin which is automatically generated.