Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body match always fails with PUT request #16

Open
xelnaga opened this issue Jun 1, 2021 · 2 comments
Open

Body match always fails with PUT request #16

xelnaga opened this issue Jun 1, 2021 · 2 comments

Comments

@xelnaga
Copy link
Contributor

xelnaga commented Jun 1, 2021

Setting up a route for a PUT request with a body will always fail to match the body.

This is because the PUT body data is keyed on the request with "content" and not "postData".

Line 34 of stub-http.internal.spec needs to use the method to determine the correct key.
xelnaga pushed a commit to xelnaga/stub-http that referenced this issue Jun 1, 2021
@russellwilsoncim
Fix for issue johanhaleby#16 with failure to match body when PUT request
dcb082d
@xelnaga
Copy link
Contributor Author

xelnaga commented Jun 1, 2021 •
edited
Loading

It appears that a PATCH request also has some problems with the body not coming through at all. Perhaps this is a limitation of NanoHttpd?

@johanhaleby
Copy link
Owner

I think it's a limitation of NanoHttpd unfortunately :(

johanhaleby pushed a commit that referenced this issue Jun 3, 2021
@xelnaga @russellwilsoncim
Fix for issue #16 with failure to match body when PUT request (#17)
1c83731 
Co-authored-by: Russell Wilson <russell.wilson@cim.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johanhaleby @xelnaga