Align publication time with StepValue rollover (micrometer-metrics#1218)

john-karp · Dec 31, 2020 · 13389a1 · 13389a1
1 parent 3b6c88a
commit 13389a1
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/push/PushMeterRegistry.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/push/PushMeterRegistry.java
@@ -71,8 +71,11 @@ public void start(ThreadFactory threadFactory) {
  logger.info("publishing metrics for " + this.getClass().getSimpleName() + " every " + TimeUtils.format(config.step()));
 
  scheduledExecutorService = Executors.newSingleThreadScheduledExecutor(threadFactory);
- scheduledExecutorService.scheduleAtFixedRate(this::publishSafely, config.step()
- .toMillis(), config.step().toMillis(), TimeUnit.MILLISECONDS);
+ // time publication to happen just after StepValue finishes the step
+ long stepMillis = config.step().toMillis();
+ long initialDelayMillis = stepMillis - (clock.wallTime() % stepMillis) + 1;
+ scheduledExecutorService.scheduleAtFixedRate(this::publishSafely,
+ initialDelayMillis, stepMillis, TimeUnit.MILLISECONDS);
  }
  }