Honor private domains flag on self, not only when passed to __call__
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 21, 2023
https://build.opensuse.org/request/show/1088132 by user mia + dimstar_suse - Update to 3.4.4: Bugfixes * Honor private domains flag on self, not only when passed to __call__ #gh/john-kurkowski/tldextract#289 - Changes in 3.4.3: Bugfixes * Speed up 10-15% over all inputs * Refactor suffix_index() to use a trie #gh/john-kurkowski/tldextract#285 Docs * Adopt PEP257 doc style - Changes in 3.4.2: Bugfixes * Speed up 10-40% on "average" inputs, and even more on pathological inputs, like long subdomains * Optimize suffix_index(): search from right to left #gh/john-kurkowski/tldextract#283 * Optimize netloc extraction: switch from regex to if/else #gh/john-kurkowski/tldextract#284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this flag check is still in the property
_PublicSuffixListTLDExtractor.tlds, the check was effectively lost in #285, when we switched away from the property.Fixes #288.