Migrate ExtractResult from namedtuple to dataclass #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re: space, at least in the test suite, not necessarily production usage, in main_test.py, memory usage does go up 8%, from 34MB to 37MB on average. |
|
Re: speed, using |
|
I want this change for future compatibility. I'm not seeing many downsides, besides the breaking change of no longer allowing accessing indexing and slicing tuple members, as there is no longer a tuple. This will be marked a breaking change. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 23, 2023
https://build.opensuse.org/request/show/1119465 by user mia + anag+factory - Update to 5.0.1: Bugfixes: * Indicate MD5 not used in a security context (FIPS compliance) #gh/john-kurkowski/tldextract#309 Misc.: * Increase typecheck aggression - Changes in 5.0.0: Breaking Changes: * Migrate `ExtractResult` from `namedtuple` to `dataclass` #gh/john-kurkowski/tldextract#306 Bugfixes: * Drop support for EOL Python 3.7 - Changes in 4.0.0: Breaking Bugfixes: * Always include suffix if private suffix enabled and private suffix exists #gh/john-kurkowski/tldextract#300 - Changes in 3.5.0: Features: * Support IPv6 addresses #gh/john-kurkowski/tldextract#298 Bugfixes: * Accept only 4 decimal octet IPv4 addresses #gh/john-kurkowski/tldextract#292 * Support IPv4 addresses with unicode dots * Reject IPv4 addresses with trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the type of this library's core type
ExtractResultfromnamedtupletodataclass.The bugfix in #300 was not the breaking change I wanted. It resulted in #305. This PR is to:
4.0.0major version bump.Open Issues