2025-05-27: Refactor highlight modules to use unified getter function #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored highlight customization modules for Glance, LazyGit, and NvimTree to use a consistent `get()` function for returning highlight specs, replacing the previous `M.highlights` table pattern. Updated plugin setup code to use the new getter function for applying highlights. Changes: - Converted `M.highlights` tables to `M.get()` functions in: - highlights/glance.lua - highlights/lazygit.lua - highlights/nvim-tree.lua - Updated plugin modules to use the new `get` function: - plugins/lsp/glance.lua - plugins/lazygit.lua - plugins/nvim-tree.lua This improves consistency, enables dynamic highlight computation, and simplifies highlight application logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the highlight customization modules for Glance, LazyGit, and NvimTree to use a consistent getter function (
get()) for returning highlight specifications. The previous approach of exporting a staticM.highlightstable is replaced with aget()function, allowing for more dynamic and maintainable highlight definitions. All plugin setup code is updated to use the new getter function when applying highlights.Changes made in this PR:
M.highlightstables toM.get()functions in:plugins/customizations/highlights/glance.luaplugins/customizations/highlights/lazygit.luaplugins/customizations/highlights/nvim-tree.luagetfunction:plugins/lsp/glance.luaplugins/lazygit.luaplugins/nvim-tree.luaWhy is it needed?
How have the changes been tested?
Screenshots (if applicable)
N/A
Checklist
get()function