Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check source code for syntax errors #44

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Check source code for syntax errors #44

merged 1 commit into from
Jan 2, 2025

Conversation

szepeviktor
Copy link
Contributor

This is a very minimalist check for syntax errors.

@szepeviktor
Copy link
Contributor Author

Viktor's troika 🐴 🐴 🐴

  1. syntax errors
  2. coding standards
  3. static analysis

@johnbillion
Copy link
Owner

Thanks Viktor. With PHPStan and PHPCS in use, does this provide any benefit?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jan 1, 2025 •
edited
Loading

It seems it doesn't. But it does: parsing is done with the PHP interpreter, not with a custom library.
All my nuclear power plants need this check :atom:

@szepeviktor
Copy link
Contributor Author

In general business-focused people don't like to bother with underlying technologies.
But I am a little scientist.

@johnbillion johnbillion merged commit 9a1b93a into johnbillion:trunk Jan 2, 2025
2 checks passed
@szepeviktor szepeviktor deleted the patch-1 branch January 2, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @johnbillion