chore: fix tests on Windows and enable it in actions (#518)

Use a gitattributes file to force text files to be checked out with LF line endings. This resolves issues on Windows with tests that compare values with the contents of files on disk.
johnfrench3 · Nov 3, 2020 · 6d8b914 · 6d8b914
1 parent 6a3a274
commit 6d8b914
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1,2 @@
+# Force checking out with LF on Windows to avoid issues in tests that read files.
+* text=auto eol=lf
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -27,8 +27,7 @@ jobs:
       fail-fast: false
       matrix:
         node-version: [10.x, 12.x, 14.x, 15.x]
-        # TODO(targos): fix and add windows-latest
-        os: [ubuntu-latest, macOS-latest]
+        os: [ubuntu-latest, macOS-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v2
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# Force checking out with LF on Windows to avoid issues in tests that read files.
		* text=auto eol=lf