-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with Nginx #157
Comments
This works on nginx, I'm running it on 2 sites. |
If you use a plugin called Nginx helper, all the urls will return 404 with the new version. That's my issue. |
I don't use Nginx Helper, and running the plugin alongside Redirection doesn't break my site. I can't see anything obvious that would cause a problem between these two plugins. The commits are listed here: https://github.com/johngodley/redirection/commits/master If it's possible for you to use |
I have been having this issue as well. I just tested the commit history and this commit is where it breaks. Anything from then on has the issue. |
I see the issue Nginx Helper overrides the wp_redirect function but doesn't return true on success. |
Ah, thanks @matt-h that's super helpful! |
^ I created that pull request to Nginx Helper which fixes this. |
Thanks Matt, I don't understand about this much, so I'm glad you could help the developer. |
wp_redirect should return true on success The core WP function does this and it should for compatibility. https://developer.wordpress.org/reference/functions/wp_redirect/ Uncovered in this issue with Redirection johngodley/redirection#157
I have released Nginx Helper plugin which address this issue. Please check and let me know if its fine. Regards, |
Thank you very much! Everything working fine now! |
Thanks everyone, closing this ticket |
Since the last update to version 2.5, redirection stopped working.
I have a blog that I have to use Nginx Helper Plugin and since I made the update of redirection to 2.5, all urls returned 404. I disabled Nginx Helper plugin and it worked fine.
Since I can't leave my website without Nginx Helper plugin, I had to downgrade redirection to 2.4.5.
Is there anything to fix it?
Thanks in advance.
The text was updated successfully, but these errors were encountered: