New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fraction bugfix #1579

Merged

johnkerl merged 1 commit into johnkerl:main from oandrew:fraction-bugfix

Jun 6, 2024

Contributor

oandrew commented Jun 6, 2024

Fix mlr fraction returning an error for 0 values:

$ echo -e 'a=1,b=0\na=2,b=1' | mlr --opprint fraction -f a,b
a b a_fraction         b_fraction
1 0 0.3333333333333333 (error)
2 1 0.6666666666666666 1

$ echo -e 'a=1,b=0' | mlr --opprint fraction -f a,b
a b a_fraction b_fraction
1 0 1          (error)

There seem to be two issues:

Division-by-zero check looks at numerator instead of the denominator.
0/0 fails, but really should return 0 instead of an error.

Fix both issues:

$ echo -e 'a=1,b=0\na=2,b=1' | ./mlr --opprint fraction -f a,b
a b a_fraction         b_fraction
1 0 0.3333333333333333 0
2 1 0.6666666666666666 1

$ echo -e 'a=1,b=0' | ./mlr --opprint fraction -f a,b
a b a_fraction b_fraction
1 0 1          0


          fraction bugfix

e4acc55

johnkerl approved these changes

View reviewed changes

Owner

johnkerl left a comment

Thank you @oandrew !!! :)

johnkerl merged commit 66abef6 into johnkerl:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet