Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations for all 39 major languages #22

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

ronaldmannak
Copy link
Contributor

This PR adds support for all 39 major App Store languages. All SwiftUI strings and localizable strings are now translated in 39 languages.
I noticed the app ignores the system language settings (except for the app menu which is always in the system language) and instead has a app language option in settings, so I added the languages to settings.
The strings have been AI translated using GPT-4o using a new SwiftUI translation app I'm working on (Pico Translate), so it is possible some translations are not 100% accurate.

@johnmai-dev johnmai-dev self-requested a review November 3, 2024 03:25
@johnmai-dev
Copy link
Owner

May I ask if Localizable.xcstrings is completely re-translated or incrementally updated? I hope to keep the original translations and only add new languages.

@ronaldmannak
Copy link
Contributor Author

@maiqingqiang It's incrementally. The default setting of Pico Translate only translates strings that are marked "needs_review" and ignores the ones that are market "translated". If you open the two branches side-by-side you should be able to confirm that the existing translations are still the original.

Copy link
Owner

@johnmai-dev johnmai-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@johnmai-dev johnmai-dev merged commit 29ae928 into johnmai-dev:main Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants