Fix injecting Swift classes #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zenangst
commented
Mar 27, 2019
•
zenangst
commented
- Adds print statement for when code coverage needs to be disabled 4eec370
- Refactors the regular expression when grep-ing for classes when injecting Swift classes dac61ec
- Adds a new condition for checking if an injected class is a Swift class 2741fcd
This is done to match the new format when grep-ing classes.
Add new condition to match swift classes. Co-Authored-By: John Holdsworth <johnno1962@users.noreply.github.com>
Co-Authored-By: John Holdsworth <johnno1962@users.noreply.github.com>
Co-Authored-By: John Holdsworth <johnno1962@users.noreply.github.com>
johnno1962
approved these changes
Mar 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.