Improve SwiftSweeper.sweepValue method #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes use of fallthrough and combines .optional, .enum to use the same implementation.
|
@johnno1962 found a minor improvement while browsing the source code, hope you like it. |
|
Thanks, don’t worry about the version numbers - I use Perforce this end. |
|
Aha nice! I'll make a mental note for that in the future :) |
Closed
Closed
oryonatan
pushed a commit
to Lightricks/InjectionIII
that referenced
this pull request
Nov 23, 2023
* Unhide only changed files * Not possible to just skip files. * Tracking previous interposes no longer required. * SwiftTrace supporting resilient classes * Fallback to find class versions * Avoid infinite loops. * Notification warning. * Give user option of replaying injections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of fallthrough and combines
.optionaland.enumto use the same implementation.