-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppCode support (fixes #147, #49) #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGTM
Looks great, let's merge this bad boy! |
@johnno1962, @zenangst Thank you so much! Do you think it's possible to build 1.8 RC2 with these changes? We plan to publish a tutorial about using AppCode together with Injection, and it would be really great to have a direct link for a new version that removes the need to rebuild in Xcode (looks strange for users). |
I'll see what I can do! :) |
@zenangst Thank you! |
Hey @yeswolf, a new version is ready and available for download here - https://github.com/johnno1962/InjectionIII/releases/tag/1.8rc2 |
Hi @zenangst, you’re not tempted to push out the new version to the AppStore? Fine by me. |
@johnno1962 yeah I think we should! |
Already out in the Store, thanks @zenangst 👍 👍 |
@zenangst @johnno1962 Thank you so much! |
This PR is a result of 1.8 review after this conversation. Finally I found that we still need to build the application in Xcode, so I've decided to implement a patch to correctly identify AppCode version. Some random notes:
~/Library/Caches/AppCode<major>.<minor>
for storing out custom DerivedData~/Library/Caches/JetBrains/AppCode<major>.<minor>
for storing out custom DerivedDataidea.path.selector
is used to identify the cache directory with DerivedData. If nothing is found for the current release, we use previous release version.Tested - works starting with AppCode 2019.3, works simultaneously in Xcode, AppCode 2020.1, AppCode 2019.3 and any other editor.