Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppCode support (fixes #147, #49) #204

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Add AppCode support (fixes #147, #49) #204

merged 1 commit into from
Mar 1, 2020

Conversation

yeswolf
Copy link
Contributor

@yeswolf yeswolf commented Feb 18, 2020

This PR is a result of 1.8 review after this conversation. Finally I found that we still need to build the application in Xcode, so I've decided to implement a patch to correctly identify AppCode version. Some random notes:

  1. AppCode < 2020.1 uses ~/Library/Caches/AppCode<major>.<minor> for storing out custom DerivedData
  2. AppCode >= 2020.1 uses ~/Library/Caches/JetBrains/AppCode<major>.<minor> for storing out custom DerivedData
  3. idea.path.selector is used to identify the cache directory with DerivedData. If nothing is found for the current release, we use previous release version.
  4. If nothing is found after all, we default to Xcode DerivedData.
  5. If some another editor is used that is not AppCode - we think it's Xcode and use Xcode's DerivedData.

Tested - works starting with AppCode 2019.3, works simultaneously in Xcode, AppCode 2020.1, AppCode 2019.3 and any other editor.

@johnno1962
Copy link
Owner

Thank you very much @yeswolf! This is a very worthwhile contribution. I’ve checked it out and it seems to work fine this end. @zenangst can you review/check it works please and I can merge.

Copy link
Owner

@johnno1962 johnno1962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM

@zenangst
Copy link
Collaborator

zenangst commented Mar 1, 2020

Looks great, let's merge this bad boy!

@zenangst zenangst merged commit 5c932af into johnno1962:master Mar 1, 2020
@yeswolf
Copy link
Contributor Author

yeswolf commented Mar 2, 2020

@johnno1962, @zenangst Thank you so much! Do you think it's possible to build 1.8 RC2 with these changes? We plan to publish a tutorial about using AppCode together with Injection, and it would be really great to have a direct link for a new version that removes the need to rebuild in Xcode (looks strange for users).

@zenangst
Copy link
Collaborator

zenangst commented Mar 2, 2020

I'll see what I can do! :)

@yeswolf
Copy link
Contributor Author

yeswolf commented Mar 2, 2020

@zenangst Thank you!

@zenangst
Copy link
Collaborator

zenangst commented Mar 2, 2020

Hey @yeswolf, a new version is ready and available for download here - https://github.com/johnno1962/InjectionIII/releases/tag/1.8rc2

@johnno1962
Copy link
Owner

Hi @zenangst, you’re not tempted to push out the new version to the AppStore? Fine by me.

@zenangst
Copy link
Collaborator

zenangst commented Mar 4, 2020

@johnno1962 yeah I think we should!

@johnno1962
Copy link
Owner

Already out in the Store, thanks @zenangst 👍 👍

@yeswolf
Copy link
Contributor Author

yeswolf commented Mar 5, 2020

@zenangst @johnno1962 Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants