Completed #10
Open
Completed #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny-rice
reviewed
Jun 17, 2020
| <style> | ||
| * { |
There was a problem hiding this comment.
Nice use of the * selector here. Other css looks good but is missing the px with the numbers.
For example see the use of px with numbers in this snippet.
.button {
width: 50px;
height: 50px;
font-size: 30px;
margin: 5px;
cursor: pointer;
}
See this page for more help https://www.w3schools.com/cssref/css_units.asp
johnny-rice
reviewed
Jun 17, 2020
| <td><input class="button" type="button" value="9" onclick="insert(9)"></td> | ||
| <td><input class="button" type="button" value="*" onclick="insert('*')"></td> | ||
| </tr> | ||
| <tr> |
There was a problem hiding this comment.
For this assignment, these are the only buttons needed for Add, Subtract, Multiply, Divide.
johnny-rice
reviewed
Jun 17, 2020
| </form> | ||
| <table> |
There was a problem hiding this comment.
These number buttons are not needed for this assignment. We want to have the input fields for users to type in the number values as we started in the template in class and the repo we pulled from originally.
johnny-rice
requested changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.