Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should pass #1

Merged
merged 3 commits into from
Oct 5, 2015
Merged

Tests should pass #1

merged 3 commits into from
Oct 5, 2015

Conversation

basarat
Copy link
Contributor

@basarat basarat commented Oct 5, 2015

Saw your comment here : TypeStrong/tsify#73 and decided to accept the challenge.

I've created issues in the tsify repository. I'll probably mark them as up for grabs ... I personally just use weback. Let me know if anything is unclear 🌹

* Fix TypeStrong/tsify#84
* Require typescript workaround for TypeStrong/tsify#85
* Ask browserify to transform the output file
@johnnyreilly
Copy link
Owner

Go for it - you have my blessing! Personally I was about to give WebPack a go just so I could demonstrate that TypeScript and Babel could have a happy marriage. (and also to give WP a bit of a test drive too )

Exciting!

@basarat
Copy link
Contributor Author

basarat commented Oct 5, 2015

I thought I was done. The remaining errors don't seem to be because of typescript :)

@basarat
Copy link
Contributor Author

basarat commented Oct 5, 2015

I use webpack btw :)

@johnnyreilly
Copy link
Owner

Okay - this looks like progress! Merging now...

@johnnyreilly johnnyreilly reopened this Oct 5, 2015
johnnyreilly added a commit that referenced this pull request Oct 5, 2015
@johnnyreilly johnnyreilly merged commit 546742b into johnnyreilly:master Oct 5, 2015
@johnnyreilly
Copy link
Owner

Okay... The upside is that we now don't get compiler errors which is real progress 👍

The downside is that the tests don't run (I suspect karma.conf.js needs to be brought in line with browserify.js) However, the real problem is that the code doesn't compile into anything that works when you run it in the browser. What's worse is, you don't actually get any error messages either and so it's kinda hard to take it further 😭

Also, when opening debug tools in Chrome it doesn't look as if the TypeScript is being served up via sourcemaps. 😭 😭

Good effort though - thanks for trying @basarat! It's probably time for me to give WebPack a go....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants