Update dependencies #105
Update dependencies #105
Conversation
👷 Deploy request for coronate pending review.Visit the deploys page to approve it
|
| "warnings": { | ||
| "number": "+A-48-42", | ||
| "number": "+A-48-42-44", |
There was a problem hiding this comment.
The open Belt generates a ton of warnings otherwise, but I'm not the biggest fan of suppressing it either
There was a problem hiding this comment.
For this warning, you can suppress it case-by-case by using open! which is probably preferable to disabling it completely. https://rescript-lang.org/docs/manual/v11.0.0/module#use-open-to-ignore-shadow-warnings
| Pull requests and bug reports are welcome! */ | ||
| type t | ||
| @get external getHelpers: numeral => t = "_" | ||
| // module Helpers = { |
There was a problem hiding this comment.
Couldn't get these to compile at all, no idea why
There was a problem hiding this comment.
Ugh. This code was always pretty messy and I don't recall the details of how/why I designed it now. I can try to take a look at it later when I get a chance.
| @@ -371,7 +373,8 @@ let make = (~windowDispatch=_ => ()) => { | |||
| ) | |||
| /* so the filename won't linger onscreen */ | |||
| /* https://github.com/BuckleScript/bucklescript/issues/4391 */ | |||
| @warning("-20") ReactEvent.Form.currentTarget(event)["value"] = "" | |||
| // TODO remove file-scoped @warning("-20") and fix this locally | |||
There was a problem hiding this comment.
this seems like a bug in rescript?
| @@ -41,18 +41,23 @@ let isLoadedDone = x => | |||
| } | |||
|
|
|||
| @react.component | |||
| let make = (~children, ~tourneyId, ~windowDispatch=_ => ()) => { | |||
| let make = (~children, ~tourneyId, ~windowDispatch=?) => { | |||
There was a problem hiding this comment.
This component and the mock for it were actively fighting against me, I have no idea why no combination I've tried works
No description provided.