Directly save the translated file from GetLocalization #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save the whole translated XML file instead of parsing just the <string> tags -> Plurals, comments, and all other tags are saved as well.
|
@oprisnik How about publishing your fork into some repository? It might solve more issues with this library. |
|
@oprisnik Hi, I have fixed your PR and made a working library from it. It's published to jcenter() so it can be directly used. https://github.com/step-up-labs/gradle-getlocalization-plugin |
|
Thanks @davidvavra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the whole translated XML file instead of parsing just the tags -> Plurals, comments, and all other tags are saved as well.
This fixes issue #4