Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Capacitor 4 #1

Merged
merged 12 commits into from
Sep 20, 2022
Merged

Migrate to Capacitor 4 #1

merged 12 commits into from
Sep 20, 2022

Conversation

Nevvulo
Copy link

@Nevvulo Nevvulo commented Sep 19, 2022 •
edited
Loading

Updates the plugin to support Capacitor 4.
I've confirmed this is working for Android and iOS, tested in the simulator and through npm run verify

Capacitor 3 vs Capacitor 4

  • Version 1.0.3 (and lower) will target Capacitor 3
  • Version 2.0.0 will target Capacitor 4

Breaking Changes

  • Version 1.x.x will solely support Capacitor 4
  • No functionality has changed

@Nevvulo Nevvulo marked this pull request as draft September 19, 2022 05:02
@Nevvulo Nevvulo changed the title Update minimum package target for Capacitor Migrate to Capacitor 4 Sep 20, 2022
@Nevvulo Nevvulo marked this pull request as ready for review September 20, 2022 02:20
@Nevvulo Nevvulo requested a review from a team September 20, 2022 02:49
anonimitoraf
anonimitoraf reviewed Sep 20, 2022
View reviewed changes
Copy link

@anonimitoraf anonimitoraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, nice job on this! I've left some q's

android/src/main/AndroidManifest.xml Show resolved Hide resolved
ios/Podfile Show resolved Hide resolved
gugahoi
gugahoi approved these changes Sep 20, 2022
View reviewed changes
Copy link

@gugahoi gugahoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok but so many things got removed it's hard to tell with confidence

@Nevvulo
Copy link
Author

Nevvulo commented Sep 20, 2022

The large number of deletions in this PR is from the removal of example, which is an example Angular Capacitor app that was automatically generated. The rest of the changes match pretty closely with the other migration PRs

@Nevvulo Nevvulo merged commit 7d3d700 into master Sep 20, 2022
@Nevvulo Nevvulo deleted the capacitor-4 branch September 20, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonimitoraf anonimitoraf anonimitoraf left review comments

@gugahoi gugahoi gugahoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nevvulo @gugahoi @anonimitoraf