Fix -D interpro option to correctly include domains in the output plot
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm! |
|
Thank you for merging, @pbnjay. Would you mind publishing a new release? Since GoReleaser is configured to use your Apple Developer ID to sign the binary, I wouldn't be able to publish a release with binaries for all OS. |
|
Release pushed: Sorry I'm slow, lots going on at the day job lately! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pbnjay,
This small PR addresses an issue caused by a recent change in how the representative property is stored in the JSON response when querying InterPro matches for a given UniProtKB accession. The change led to
lollipopsfailing to include any domains in the output plot when the-D interprooption is used.