Skip to content

add gh and rsync for cypress-visual-regression so all the CI jobs can use the same image #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nkeyes
Copy link

@nkeyes nkeyes commented Oct 3, 2024

add gh and rsync for cypress-visual-regression so all the CI jobs can use the same image

@nkeyes nkeyes requested review from zreisman and edlc-agero October 3, 2024 00:16
Copy link

@zreisman zreisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkeyes You know this needs to be rebuilt and uploaded to docker hub?

@@ -19,6 +19,8 @@ RUN sudo apt-get update && sudo apt-get install -y --no-install-recommends \
dpkg-dev \
# Rails dep
ffmpeg \
# for CI
Copy link

@zreisman zreisman Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of vague. The whole image is for CI

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol fair. updated.

@nkeyes nkeyes requested a review from smasry October 3, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants