Keep newline/tab escapes in quoted strings (fix certificate serializing) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR was closed by mistake. Reopened it. |
Keep escape backslash for newline/tab characters. Parsing still
differs from shell syntax but keeps string structure intact.
Example certificate data
VAR="---BEGIN---\r\n---END---"
now becomes
"---BEGIN---\r\n---END---"
instead of
"---BEGIN---rn---END---"
johnbergvall
force-pushed
the
develop
branch
from
b425927 to
6080f4d
Compare
|
I've rebased this onto the latest |
|
I'll review this PR ASAP. Thank you for the contributing! |
|
Merged! Thank you for the patch, and for helping us make django-environ better. |
sergeyklay
added a commit
that referenced
this pull request
Sep 15, 2021
…ng) (#296) Limit backslash escape removal for quoted newlines Keep escape backslash for newline/tab characters. Parsing still differs from shell syntax but keeps string structure intact. Example certificate data VAR="---BEGIN---\r\n---END---" now becomes "---BEGIN---\r\n---END---" instead of "---BEGIN---rn---END---" Co-authored-by: Serghei Iakovlev <egrep@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change parsing of quoted strings to not remove \ before \r, \n and \t to allow basic formatting and certificate serializing.
Also include optional \r in delimiter when splitting string to multiple lines for better compatibility with PEM-certificates and MIME-headers
Example certificate data
VAR="---BEGIN---\r\n---END---"now becomes
r"---BEGIN---\r\n---END---"instead of
r"---BEGIN---rn---END---"This makes linebreaks work correctly with Env().str('VAR', multiline=True) as well