Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIN Code range and union territories in en_IN address provider #2091

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

wh0th3h3llam1
Copy link
Contributor

What does this change

Updates the address provider for en_IN to add union territories and PIN code ranges for states

What was wrong

No state / union territories pin code specified

How this fixes it

Add state / union territories pin codes with ranges

Fixes #2089

"Jammu and Kashmir",
"Ladakh",
"Lakshadweep",
("Pondicherry, Puducherry"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine being a tuple?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make them all tuples, even if they just have one element

"Jammu and Kashmir",
"Ladakh",
"Lakshadweep",
("Pondicherry, Puducherry"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make them all tuples, even if they just have one element

faker/providers/address/en_IN/__init__.py Show resolved Hide resolved
@fcurella fcurella self-requested a review September 4, 2024 14:26
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 2a25996 into joke2k:master Sep 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update address provider for en_IN
2 participants