Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Zulu (zu_ZA) address provider and corresponding tests #2143

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

AliYmn
Copy link
Contributor

@AliYmn AliYmn commented Nov 28, 2024

What does this change

Adds a new AddressProvider for the zu_ZA locale (Zulu, South Africa) to generate realistic fake addresses, including city names, street names, postal codes, and countries relevant to the region.

What was wrong

The Faker library lacked support for the zu_ZA locale's address data, and the initial postal code format generated incorrect 5-digit codes, causing tests to fail.

How this fixes it

Introduces accurate locale-specific data and corrects the postal code format to produce 4-digit codes matching South African standards, ensuring all tests pass.

Fixes #2105

Checklist

  • I have read the documentation about CONTRIBUTING
  • I have read the documentation about Coding style
  • I have run make lint

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit d9d70c4 into joke2k:master Jan 3, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants