Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins -> PiHole Device Sync there is no IP shown #418

Closed
ace16vitamine opened this issue Sep 10, 2023 · 6 comments
Closed

Plugins -> PiHole Device Sync there is no IP shown #418

ace16vitamine opened this issue Sep 10, 2023 · 6 comments
Labels
next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress.

Comments

@ace16vitamine
Copy link

Built on: 2023-09-10 | Version: v23.9.10

In Plugins -> PiHole Device Sync there is no IP shown (it is the vendor Name displayd)

See screenshot
Bildschirmfoto 2023-09-10 um 13 14 36

@jokob-sk
Copy link
Owner

Could you please share the settings for the PiHole plugin and how you have mapped the files in your docker compose file?

@jokob-sk jokob-sk added the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Sep 10, 2023
@ace16vitamine
Copy link
Author

It was a fresh installation, I reinstalled it already but the files are right mapped in docker. For me it seems that this comes from the SQL Select.

I try it again and post the infos

@ace16vitamine
Copy link
Author

I found a similar problem.

It is not the Mac shown -> Its the Hostname

Bildschirmfoto 2023-09-10 um 15 26 58

jokob-sk added a commit that referenced this issue Sep 11, 2023
@jokob-sk
Copy link
Owner

Hey,
Can you re-download the latest _dev image and give it a try? the IP should be now populated.

If you are using an existing config:

remove the PIHOLE_CMD setting from your pialert.conf file or replace the value in the Settings page with SELECT n.hwaddr AS Object_PrimaryID, 'null' AS Object_SecondaryID, datetime() AS DateTime, na.ip AS Watched_Value1, n.lastQuery AS Watched_Value2, na.name AS Watched_Value3, n.macVendor AS Watched_Value4, {s-quote}null{s-quote} AS Extra, n.hwaddr AS ForeignKey FROM EXTERNAL_PIHOLE.Network AS n LEFT JOIN EXTERNAL_PIHOLE.Network_Addresses AS na ON na.network_id = n.id WHERE n.hwaddr NOT LIKE {s-quote}ip-%{s-quote} AND n.hwaddr <> {s-quote}00:00:00:00:00:00{s-quote};

@jokob-sk jokob-sk added the next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. label Sep 11, 2023
@jokob-sk
Copy link
Owner

Please let me know if the name gets populated as well. Thanks in advance

@jokob-sk
Copy link
Owner

Released in today's hotfix (23.9.11). You need to complete the below step if you have saved the settings on the 23.9.10 version:

remove the PIHOLE_CMD setting from your pialert.conf file or replace the value in the Settings page with the below value:

SELECT n.hwaddr AS Object_PrimaryID, 'null' AS Object_SecondaryID, datetime() AS DateTime, na.ip AS Watched_Value1, n.lastQuery AS Watched_Value2, na.name AS Watched_Value3, n.macVendor AS Watched_Value4, {s-quote}null{s-quote} AS Extra, n.hwaddr AS ForeignKey FROM EXTERNAL_PIHOLE.Network AS n LEFT JOIN EXTERNAL_PIHOLE.Network_Addresses AS na ON na.network_id = n.id WHERE n.hwaddr NOT LIKE {s-quote}ip-%{s-quote} AND n.hwaddr <> {s-quote}00:00:00:00:00:00{s-quote};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress.
Projects
None yet
Development

No branches or pull requests

2 participants