Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to select which subnets to add to the scan (Mikrotik plugin) #836

Closed
stanelie opened this issue Oct 10, 2024 · 13 comments
Closed

A way to select which subnets to add to the scan (Mikrotik plugin) #836

stanelie opened this issue Oct 10, 2024 · 13 comments
Labels
Feature request➕ New feature or request next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress.

Comments

@stanelie
Copy link

stanelie commented Oct 10, 2024

Hello.

My Mikrotik router is managing 8 networks, but I only care to scan for 2 of them. So, I would like to exclude them from the scan results (Mikrotik plugin). They are on distinct subnets.

Example : I would like to exclude the building's Guests network, so I don't get alerts every time someone on the sidewalk connects to it.

It would be useful to me to have a way to exclude certain subnets, or, to have a way to choose which subnets I would like to include in the scan.

Thanks!

@stanelie stanelie added the Feature request➕ New feature or request label Oct 10, 2024
@jokob-sk
Copy link
Owner

Hi @stanelie,

I won't be implementing plugin specific exclusions as that would overcomplicate the code and thus maintenance (e.. G. That exclusion settings would have to be configurable across all scanner plugins)

However I think that you should be able to exclude devices with the already available settings. Please check these docs for details:
https://github.com/jokob-sk/NetAlertX/blob/main/docs/NOTIFICATIONS.md

Let me know your thoughts.
J

@jokob-sk jokob-sk added the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Oct 10, 2024
@jokob-sk
Copy link
Owner

Also, please use the feature template in the future as it allows me to understand what you tried, though of and the use case. I'm not sure for example if you have considered above.

Templates help me not to get burned out of maintaining this project as they reduce the back and forth communication, so that I can focus my time better.

Thanks in advance.

@stanelie
Copy link
Author

Oh!
Ignored IPs from the New Devices section is the feature I was looking for.

However, after deleting all my devices and having the Mikrotik plugin re-add them, those that I excluded with the filter "10.10.%.%", as per the documentation, were still added to the list of devices (I want to not add all the 10.10.x.x devices).

Sorry about the template, I will be more careful.
Thanks!

@jokob-sk
Copy link
Owner

Nah, all good.

I think the value should then be 10.10.%. Let me know if that works.

Thanks,
J

@stanelie
Copy link
Author

I've tried with both 10.10.%. and 10.10.% , and I still get devices added in the 10.10.x.x range.

Thoughts?

jokob-sk pushed a commit that referenced this issue Oct 11, 2024
@jokob-sk
Copy link
Owner

Hi @stanelie ,

I think I found the issue. The correct value should be 10.10.% - without the . at the end.

This should be fixed in the next release. It would be great if you could test this. Can you please switch to the netalertx-dev docker image (backup everything at first), in about 15 minutes (or after the last action finishes) from now.

Thanks in advance,
j

@jokob-sk jokob-sk added the next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. label Oct 11, 2024
@stanelie
Copy link
Author

No luck. I still see the excluded subnet in the devices list.

@jokob-sk
Copy link
Owner

Hi, thanks for checking.

Just to clarify, this will stop the devices being added. However once they are in the app, they will remain seen. IF you delete one of the devices, will it reappear?

@stanelie
Copy link
Author

stanelie commented Oct 11, 2024

Everytime I test this feature, I previously click on Delete All Devices in the maintenance tools menu.

They still reappear.

Edit: typo

jokob-sk pushed a commit that referenced this issue Oct 12, 2024
@jokob-sk
Copy link
Owner

Thanks @stanelie - I think I overlooked one query - weird that no one complained about this before.

Hopefully now this truly works now.

It would be great if you could test this. Can you please switch to the netalertx-dev docker image (backup everything at first), in about 15 minutes (or after the last action finishes) from now.

Thanks in advance,
j

@stanelie
Copy link
Author

It works!
🎉

@jokob-sk
Copy link
Owner

Yayyyy 🍾 🙂

@jokob-sk
Copy link
Owner

I will close this as released and solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request➕ New feature or request next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress.
Projects
None yet
Development

No branches or pull requests

2 participants