Fixes to work using a reverse proxy #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnviana
changed the title
|
@alnviana thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a reverse proxy with Subpath, the notifications don't load. The call is made to http://host/api/user_notifications.json instead of http://host/netalertx/api/user_notifications.json.
When I compared it to the table_devices.json request (which works), I realized that it probably works there because it's relative. When I changed it manually on the server to test, the notifications appeared.
I don't think changing this should cause any problems, as table_devices.json already works like this. However, as everything in IT is strange, any small change can cause unexpected errors, so I suggest you test it too. :)
Not working:
Working:
Edit:
I saw some other requests that were giving the same problem, so I decided to look up everything that used '/api' and found these two more.
table_appevents.json
table_notifications.json
