Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore manual naming of static leases using comments for MKSCAN + cleanups #940

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

kpolszewski
Copy link
Contributor

reopen of #938

It was removed as part of #759 (exactly: https://github.com/jokob-sk/NetAlertX/pull/759/files#diff-3141c3ddff99ee9cccc877150d8bd75a6a5227c3f049d6fe7809ef27b77cbb71L91 ), however comments are used to provide custom device names for Mikrotik's static leases

I have:

  • removed unused imports and unused "ips" param,
  • created the device_name variable that tries to determine the name in order: comment>hostname>"(unknown)" fallback (so nslookup and other plugins can continue resolving from here)
  • used all watchedValues that are defined in config.json

@jokob-sk
Copy link
Owner

jokob-sk commented Jan 7, 2025

Thanks @kpolszewski 💪 sorry for the confusion earlier

@jokob-sk jokob-sk merged commit c828018 into jokob-sk:main Jan 7, 2025
1 check passed
@jokob-sk
Copy link
Owner

jokob-sk commented Jan 7, 2025

Can you also update readme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants