chore(clippy): make clippy happy (gakonst#1230)

joleeee · May 6, 2022 · ce3ebae · ce3ebae
1 parent 2768a6b
commit ce3ebae
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 15 deletions.
diff --git a/ethers-contract/ethers-contract-abigen/src/contract.rs b/ethers-contract/ethers-contract-abigen/src/contract.rs
@@ -133,7 +133,7 @@ impl Context {
  let contract = quote! {
  #struct_decl
 
- impl<'a, M: #ethers_providers::Middleware> #name<M> {
+ impl<M: #ethers_providers::Middleware> #name<M> {
  /// Creates a new contract instance with the specified `ethers`
  /// client at the given `Address`. The contract derefs to a `ethers::Contract`
  /// object

diff --git a/ethers-contract/src/multicall/multicall_contract.rs b/ethers-contract/src/multicall/multicall_contract.rs
@@ -33,7 +33,7 @@ mod multicallcontract_mod {
  f.debug_tuple(stringify!(MulticallContract)).field(&self.address()).finish()
  }
  }
- impl<'a, M: Middleware> MulticallContract<M> {
+ impl<M: Middleware> MulticallContract<M> {
  #[doc = r" Creates a new contract instance with the specified `ethers`"]
  #[doc = r" client at the given `Address`. The contract derefs to a `ethers::Contract`"]
  #[doc = r" object"]

diff --git a/ethers-core/src/utils/anvil.rs b/ethers-core/src/utils/anvil.rs
@@ -51,7 +51,7 @@ impl AnvilInstance {
 
 impl Drop for AnvilInstance {
  fn drop(&mut self) {
- let _ = self.pid.kill().expect("could not kill anvil");
+ self.pid.kill().expect("could not kill anvil");
  }
 }
 

diff --git a/ethers-core/src/utils/ganache.rs b/ethers-core/src/utils/ganache.rs
@@ -51,7 +51,7 @@ impl GanacheInstance {
 
 impl Drop for GanacheInstance {
  fn drop(&mut self) {
- let _ = self.pid.kill().expect("could not kill ganache");
+ self.pid.kill().expect("could not kill ganache");
  }
 }
 

diff --git a/ethers-core/src/utils/geth.rs b/ethers-core/src/utils/geth.rs
@@ -47,7 +47,7 @@ impl GethInstance {
 
 impl Drop for GethInstance {
  fn drop(&mut self) {
- let _ = self.pid.kill().expect("could not kill geth");
+ self.pid.kill().expect("could not kill geth");
  }
 }
 

diff --git a/ethers-etherscan/src/contract.rs b/ethers-etherscan/src/contract.rs
@@ -305,14 +305,14 @@ impl Client {
  }
  if resp.result.starts_with("Contract source code not verified") {
  if let Some(ref cache) = self.cache {
- let _ = cache.set_abi(address, None);
+ cache.set_abi(address, None);
  }
  return Err(EtherscanError::ContractCodeNotVerified(address))
  }
  let abi = serde_json::from_str(&resp.result)?;
 
  if let Some(ref cache) = self.cache {
- let _ = cache.set_abi(address, Some(&abi));
+ cache.set_abi(address, Some(&abi));
  }
 
  Ok(abi)
@@ -350,14 +350,14 @@ impl Client {
  let response: Response<Vec<Metadata>> = self.get_json(&query).await?;
  if response.result.iter().any(|item| item.abi == "Contract source code not verified") {
  if let Some(ref cache) = self.cache {
- let _ = cache.set_source(address, None);
+ cache.set_source(address, None);
  }
  return Err(EtherscanError::ContractCodeNotVerified(address))
  }
  let res = ContractMetadata { items: response.result };
 
  if let Some(ref cache) = self.cache {
- let _ = cache.set_source(address, Some(&res));
+ cache.set_source(address, Some(&res));
  }
 
  Ok(res)

diff --git a/ethers-middleware/src/transformer/ds_proxy/factory.rs b/ethers-middleware/src/transformer/ds_proxy/factory.rs
@@ -63,7 +63,7 @@ mod dsproxyfactory_mod {
  f.debug_tuple(stringify!(DsProxyFactory)).field(&self.address()).finish()
  }
  }
- impl<'a, M: Middleware> DsProxyFactory<M> {
+ impl<M: Middleware> DsProxyFactory<M> {
  #[doc = r" Creates a new contract instance with the specified `ethers`"]
  #[doc = r" client at the given `Address`. The contract derefs to a `ethers::Contract`"]
  #[doc = r" object"]

diff --git a/ethers-providers/src/pending_escalator.rs b/ethers-providers/src/pending_escalator.rs
@@ -190,7 +190,7 @@ where
  poll_broadcast_fut!(cx, this, fut);
  }
  Sleeping(delay) => {
- let _ready = futures_util::ready!(delay.as_mut().poll(cx));
+ futures_util::ready!(delay.as_mut().poll(cx));
  // if broadcast timer has elapsed and if we have a TX to
  // broadcast, broadcast it
  if this.last.elapsed() > *this.broadcast_interval {

diff --git a/ethers-providers/src/pending_transaction.rs b/ethers-providers/src/pending_transaction.rs
@@ -172,7 +172,7 @@ impl<'a, P: JsonRpcClient> Future for PendingTransaction<'a, P> {
 
  match this.state {
  PendingTxState::InitialDelay(fut) => {
- let _ready = futures_util::ready!(fut.as_mut().poll(ctx));
+ futures_util::ready!(fut.as_mut().poll(ctx));
  tracing::debug!("Starting to poll pending tx {:?}", *this.tx_hash);
  let fut = Box::pin(this.provider.get_transaction(*this.tx_hash));
  rewake_with_new_state!(ctx, this, PendingTxState::GettingTx(fut));

diff --git a/ethers-solc/src/sourcemap.rs b/ethers-solc/src/sourcemap.rs
@@ -134,7 +134,7 @@ impl AsRef<str> for Jump {
  }
 }
 
-impl<'a> fmt::Display for Jump {
+impl fmt::Display for Jump {
  fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
  f.write_str(self.as_ref())
  }
@@ -176,7 +176,7 @@ pub struct SourceElement {
  pub modifier_depth: usize,
 }
 
-impl<'a> fmt::Display for SourceElement {
+impl fmt::Display for SourceElement {
  fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
  write!(
  f,
@@ -199,7 +199,7 @@ struct SourceElementBuilder {
  pub modifier_depth: Option<usize>,
 }
 
-impl<'a> fmt::Display for SourceElementBuilder {
+impl fmt::Display for SourceElementBuilder {
  fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
  if self.offset.is_none() &&
  self.length.is_none() &&