New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in detection models (ssd), in predict output : ymin and ymax are swapped #674

Closed

fantes opened this issue Dec 12, 2019 · 3 comments · Fixed by #690

Assignees

Labels

Contributor

fantes commented Dec 12, 2019

ie ymax < ymin ,

change in dd to do here : https://github.com/jolibrain/deepdetect/blob/master/src/backends/caffe/caffelib.cc#L2560 (replace ymax by ymin and reverse) , reference in caffe : https://github.com/jolibrain/caffe/blob/master/src/caffe/util/bbox_util.cpp#L2105 (same in cuda)
change in platform to do here (ymin - ymax)
https://github.com/alx/react-bounding-box/blob/master/src/react-bounding-box.js#L394

beniz added the type:bug label

beniz assigned fantes

Contributor

YaYaB commented Jan 15, 2020

Please make a release when this is pushed to master as it has a big impact for those using detection models.

fantes mentioned this issue

Fixed inversion of ymin and ymax in detection models output #690

Merged

Collaborator

alx commented Jan 16, 2020

Fixed in react-bounding-box v0.5.3: https://www.npmjs.com/package/react-bounding-box/v/0.5.3

Contributor Author

fantes commented Jan 16, 2020

Fixed in react-bounding-box v0.5.3: https://www.npmjs.com/package/react-bounding-box/v/0.5.3

👍

beniz closed this as completed in #690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment