Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inversion of ymin and ymax in detection models output #690

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

fantes
Copy link
Contributor

@fantes fantes commented Jan 16, 2020

FIX #674

@beniz beniz changed the title BUGFIX on ymin and ymax outputs for detection models Fixed inversion of ymin and ymax in detection models output Jan 16, 2020
@beniz
Copy link
Collaborator

beniz commented Jan 20, 2020

Thanks. Beware I believe this PR may break image cropping in chains, especially this line: https://github.com/jolibrain/deepdetect/blob/master/src/chain_actions.cc#L91

Maybe update the PR so that it becomes:

cv::Rect roi(cxmin,cymax,cxmax-cxmin,cymax-cymin);

@beniz
Copy link
Collaborator

beniz commented Jan 20, 2020

@fantes fantes force-pushed the fix_detection_ymin_ymax branch from 6a5e606 to 930e1ea Compare January 20, 2020 07:38
@fantes
Copy link
Contributor Author

fantes commented Jan 20, 2020

Thanks. Beware I believe this PR may break image cropping in chains, especially this line: https://github.com/jolibrain/deepdetect/blob/master/src/chain_actions.cc#L91

Maybe update the PR so that it becomes:

cv::Rect roi(cxmin,cymax,cxmax-cxmin,cymax-cymin);

done

1 similar comment
@fantes
Copy link
Contributor Author

fantes commented Jan 20, 2020

Thanks. Beware I believe this PR may break image cropping in chains, especially this line: https://github.com/jolibrain/deepdetect/blob/master/src/chain_actions.cc#L91

Maybe update the PR so that it becomes:

cv::Rect roi(cxmin,cymax,cxmax-cxmin,cymax-cymin);

done

@fantes fantes force-pushed the fix_detection_ymin_ymax branch 2 times, most recently from 70a6790 to e98ca38 Compare February 4, 2020 14:55
inverted ymin and ymax in detection output : adapt chains

add fix to trt and ncnn
@fantes fantes force-pushed the fix_detection_ymin_ymax branch from e98ca38 to 96d2f81 Compare February 4, 2020 15:16
@beniz beniz merged commit bb28b93 into jolibrain:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in detection models (ssd), in predict output : ymin and ymax are swapped
2 participants