Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis with no test #327

Closed
wants to merge 105 commits into from
Closed

Travis with no test #327

wants to merge 105 commits into from

Conversation

jsaksris
Copy link
Contributor

Add Travis to deepdetect with no test script.

fixing eigen3 problem based on
https://github.com/beniz/deepdetect/pull/276

@beniz
Copy link
Collaborator

beniz commented Jun 26, 2017

Thanks. Several things before integration:

  • Please squash all your commits into a single one
  • Remove the .travis.yml.orig file that seems to be useless
  • Can you explain your changes to Cuda.cmake ?
  • Could you explain your changes to CMakeLists.txt ? I see hard-coded paths such as /usr/include and I don't think there should be there, unless Travis platforms were complaining in some ways. In that latter case, please update this PR with the Travis error messages.

@jsaksris
Copy link
Contributor Author

Removing hard-coded paths resolved in following error.
This fix was part of the changes suggested by https://github.com/beniz/deepdetect/pull/276

screen shot 2017-06-26 at 11 45 38 am

@jsaksris jsaksris force-pushed the master branch 3 times, most recently from 030eff3 to 6ee317f Compare June 26, 2017 13:04
@jsaksris jsaksris closed this Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants