Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Symfony 6 #55

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Add support for Symfony 6 #55

merged 1 commit into from
Jun 6, 2023

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Jun 5, 2023 •
edited
Loading

Fix #54

Also

  • drop support for PHP < 8
  • refactore code base
  • refactore tests
  • add a way to run symfony serve in the test/app directory to manually test the bundle and the error pages

lyrixx
lyrixx reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wahoo'😍this is very clean
. Thanks 👍🏼
Only one little typo and we can merge imho

tests/Command/GifOptimizerCommandTest.php Outdated Show resolved Hide resolved
@pyrech pyrech merged commit 3418195 into main Jun 6, 2023
@pyrech pyrech deleted the sf-6 branch June 6, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx left review comments

@damienalexandre damienalexandre damienalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add compatibility and tests with Symfony 6
3 participants
@pyrech @damienalexandre @lyrixx