Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RN56: Use sdkVersion / buildToolsVersion from project if set #128

Closed
wants to merge 2 commits into from
Closed

Support RN56: Use sdkVersion / buildToolsVersion from project if set #128

wants to merge 2 commits into from

Conversation

drew-r
Copy link

@drew-r drew-r commented Jul 24, 2018 •
edited
Loading

Fixes

The SDK Build Tools revision (23.0.1) is too low for project ':react-native-fetch-blob'. Minimum required is 25.0.0

@yeomann
Copy link

yeomann commented Jul 24, 2018

where is project variable coming from, did you test it. safe way I know of isrootProject

yeomann added a commit to yeomann/rn-fetch-blob that referenced this pull request Jul 24, 2018
@yeomann
improvement way to get root SDK versions
a4abef9 
just added a function which acts like a ternary with fallback option. Hence, less cluttered "def" variables  
additionally, changed the SDK values from 23 to 26 as per new changes from react-native and Android

Android Target API Level 26 will be required in August 2018.
https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html

And the React Native team is already working on this:
facebook/react-native#18095
facebook/react-native#17741

PS: I am aware of this PR joltup#128 but first its still targeting old SDK values i.e 23 as fallback and secondly I am not sure of the use of `project` to get the value instead of proper way i.e `rootProject.ext` to get the property value.
@yeomann yeomann mentioned this pull request Jul 24, 2018
Merged
@Traviskn
Copy link

Traviskn commented Aug 6, 2018

Thank you for your PR, we decided to go with another one that implemented a similar fix for this same problem

@Traviskn Traviskn closed this Aug 6, 2018
cguino pushed a commit to BeApp/rn-fetch-blob that referenced this pull request Jul 5, 2023
@RonRadtke
Merge pull request joltup#128 from mmathewsTableau/master
2053273 
Adding File Transforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drew-r @yeomann @Traviskn