-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new version of VFS API #205
base: master
Are you sure you want to change the base?
Conversation
Thank you! later today I'll double check that all the unit tests work, merge, and release! |
@haberturdeur what version of v5.4 are you using? I checked out v5.4-beta1 and am hitting many errors pertaining to the new definitions like: /Users/brianpugh/esp-idf/tools/unit-test-app/components/littlefs/src/esp_littlefs.c:372:8: error: unknown type name 'esp_vfs_dir_ops_t'; did you mean 'esp_vfs_id_t'?
372 | static esp_vfs_dir_ops_t s_vfs_littlefs_dir = {
| ^~~~~~~~~~~~~~~~~
| esp_vfs_id_t |
Looks like espressif/esp-idf:v5.4-beta might be tagged incorrectly? @haberturdeur 's commits are on espressif/esp-idf:master though. I was able to checkout harberturdeur:master and run unit tests. Test Setup
Test Results
logs
I rebuilt and re-ran the tests on IDF v5.3.1 and joltwallet:master and got the same results, so maybe the problem is something I'm doing wrong. I haven't analyzed the test results at all yet. Always trying to minimize RAM usage in our application though -- happy to run some dev builds with v5.4-beta when unit tests get sorted out. |
It is not tagged incorrectly. I assume, it just didn't make it to that round of testing and therefore that tag. It is in the release/v5.4 branch, so it should be included in the v5.4 release. I will take a look at those failing tests. |
when running the unit tests I encountered two issues:
Note: the rest of the failures in your run seem to be caused by the failed |
The code looks good, and I have confirmed that tests are passing. I'll merge and release this as soon as esp-idf v5.4 is released (just in case something changes). I'll keep an eye out on it, but don't hesitate to ping me! |
Hi,
In release v5.4 IDF will be switching to new version of VFS API, which will become the recommended one for users to use.
(Further documentation of the API and switch to new API for IDF-provided file-systems are in-progress)
This PR modifies esp_littlefs to use the new version of the API in all releases from v5.4 onwards.
Thank you!